Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlEntityQuery#sum suports Optional type. #316

Merged

Conversation

HidekiSugimoto189
Copy link
Contributor

Fixed a bug that caused a type check error when executing the SqlEntityQuery#sum method on an Entity class that declared a nullable numeric type column in a field such as Optional<BigDecimal>.
Fixed a type check error when executing SqlEntityQuery#sum method.

In the case of a field of Optional type, it is modified to determine whether the Generic type of Optional and the specified class (BigDecimal in the above case) are numeric types or not.


null可な数値型カラムを Optional<BigDecimal> のようなフィールドで宣言したEntityクラスに対して
SqlEntityQuery#sum メソッドを実行した場合、型チェックエラーになる不具合を修正。

Optional型のフィールドの場合はOptionalのGeneric型と指定されたクラス(上記の場合はBigDecimal)が数値型かどうかを判定するように修正している。

@coveralls
Copy link

Coverage Status

coverage: 90.176% (+0.01%) from 90.166%
when pulling 7a68200 on feature/fsqlentityquery_sum_supports_optional
into 775d572 on release/v0.x.

@shout-star shout-star merged commit 217d183 into release/v0.x Nov 3, 2023
1 check passed
@shout-star shout-star deleted the feature/fsqlentityquery_sum_supports_optional branch November 3, 2023 12:44
@HidekiSugimoto189 HidekiSugimoto189 added this to the v0.26.7 milestone Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants