Send GoalStateV2 from DPM, NCM and ACA #704
Conversation
There was a problem hiding this comment.
@DavidLiu506 Please take a look at the following few comments. Thanks.
| - port: 50001 | ||
| protocol: TCP | ||
| targetPort: 50001 |
There was a problem hiding this comment.
Would this change block port 9014 for REST APIs?
There was a problem hiding this comment.
This is for grpc configure, we can add another service for restful.
services/data_plane_manager/src/main/java/com/futurewei/alcor/dataplane/config/Config.java
Outdated
Show resolved
Hide resolved
...e_manager/src/main/java/com/futurewei/alcor/dataplane/client/grpc/DataPlaneClientImplV2.java
Show resolved
Hide resolved
...e_manager/src/main/java/com/futurewei/alcor/dataplane/client/grpc/DataPlaneClientImplV2.java
Show resolved
Hide resolved
...data_plane_manager/src/main/java/com/futurewei/alcor/dataplane/service/impl/DhcpService.java
Show resolved
Hide resolved
...java/com/futurewei/alcor/netwconfigmanager/service/impl/GoalStatePersistenceServiceImpl.java
Show resolved
Hide resolved
| - containerPort: 50001 | ||
| protocol: TCP |
There was a problem hiding this comment.
@DavidLiu506 Why we need to change 8080 to 50001 here? Is this for grpc connection?
There was a problem hiding this comment.
Yes, this is for grpc connection.
| - port: 50001 | ||
| protocol: TCP | ||
| targetPort: 50001 |
There was a problem hiding this comment.
@DavidLiu506 Do we need to include port spec for restful here too?
There was a problem hiding this comment.
Yes, we can add restful configure after restful api fix.
| if (!finishLatch.await(1, TimeUnit.MINUTES)) { | ||
| LOG.warn("Send goal states can not finish within 1 minutes"); | ||
| return Arrays.asList("Send goal states can not finish within 1 minutes"); | ||
| } |
There was a problem hiding this comment.
@DavidLiu506 Do we know which goalstate or which ncm cannot sent to? If we do, can we put the id or uri in the log and return results?
There was a problem hiding this comment.
BTW, can we put 1 mins as a variable in application.properties?
There was a problem hiding this comment.
NCM managed by linked, there only one goal state v2 send to NCM.
There was a problem hiding this comment.
Talked with James, NCM already have ACA response information. DPM don't need to know it.
1 Merge GoalState in DPM and send to NCM, wait for NCM response.
2 Send GoalState from NCM to ACA and wait for all ACA response.
3 Improve NCM performance.
4 Use linkerd load balance grpc request for NCM.