This repository has been archived by the owner on Apr 1, 2023. It is now read-only.
Added delete node function. Fixed #97 and #98 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Address the Issue #64 |
yanmo96
changed the title
|
Hi @cj-chung Thanks |
cj-chung
reviewed
Sep 2, 2022
| @@ -22,5 +22,6 @@ const SUBNET string = "subnet:" | |||
| const Router string = "router:" | |||
| const SECURITYGROUP string = "securityGroup:" | |||
| const NETCONFIG string = "netconfig:" | |||
| const NODEGROUP string = "nodeGroup:" | |||
|
|
|||
| const ALCORURL string = "10.213.43.77" | |||
There was a problem hiding this comment.
@yanmo96 Should we get ALCORURL from service-config protobuf?
|
@yanmo96 Please create a merak-network service container on .77 with your latest PR. We need to verify the change. |
This was
linked to
issues
Sep 2, 2022
|
Will improve the code once node bulk deletion ability is added to Alcor futurewei-cloud/alcor#755 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the delete node function from #64
Address the the issue #97 , which is caused by a wait group in the wrong place. Which stoped process to write into channel, if it cannot write into channel, the Wait will never finish. Then the entire program will hang.
Address the issue #98 , fixed by empty the channel after every time I retrieve information from it.