Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all good work. It's worth saying that this PR isn't designed to be merged, but rather an easier place for me to document suggestions - it may work out better to address the changes below, push to this PR, and then I re-review but we can talk about that separately.
The repository itself is quite messy and needs some refinement - I know you're still working on it. The structure needs to be thought about more carefully and you should put yourself in the position of a client, i.e., how easy is their journey through this guide/tutorial?
In addition, these patterns should showcase our ability to write clean, well-documented code, with easy to understand and follow documentation.
To build on the points above in more detail, here are the changes I think you should make:
Dataset
object?run_demo.py
), calling on the various functions that perform the particular steps.model_server
andmonitoring_server
, can we have a singleserver
directory which contains two sub-directories calledmodel
andmonitoring
?There’s a lot there and it’s mostly nitpicking. These patterns want to showcase our ability so they need to be great. Happy to chat about any points, and I’ll update with anything else I spot.