Set private access for remote state storage container #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it was intentional to set access to the remote state container with
container_access_type
ascontainer
. Seems likeprivate
would be a better setting. Terraform remote state contains lots and lots of plain-text secrets and so you don't want to enable any kind of public access.Not sure about the downstream effects elsewhere inside Matcha from this change, but if I'm not mistaken the current setting might be risky from a security perspective.
Checklist
Please ensure you have done the following:
Type of change
Tick all those that apply: