Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement semantic tokens #40

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Implement semantic tokens #40

wants to merge 3 commits into from

Conversation

fwcd
Copy link
Owner

@fwcd fwcd commented Sep 4, 2021 •
edited
Loading

Fixes #39

Provide semantic highlighting in Curry documents.

To do:

  • Add semantic tokens request for full documents
  • Implement HasSemanticTokens for syntax tree nodes containing Idents
  • Implement HasSemanticTokens for syntax tree nodes containing QualIdents (see HasQualIdentifiers for examples)
  • Fix responsiveness issues: Currently, the AST in the index store may become out-of-sync with what the user types. Fully responsive semantic tokens may require us to implement something similar to Provide fully context-aware completions #16 where a (possibly broken) AST is parsed in real-time.

Future work:

  • Implement delta semantic tokens (investigate how much the lsp abstracts away for us there)

@fwcd fwcd added enhancement New feature or request lsp feature A new (not yet implemented) Language Server Protocol feature labels Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request lsp feature A new (not yet implemented) Language Server Protocol feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement semantic highlighting
1 participant
@fwcd