Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move initialization into doInitialize and report progress #74

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

fwcd
Copy link
Owner

@fwcd fwcd commented Oct 14, 2024

Supersedes #24

Performing our initialization (indexing and compiling all modules) before responding to the initialize request, instead of in the initialized notification, seems to be a cleaner way of handling required initialization, since language features like go-to-definition will be fully disabled instead of hanging. Additionally, the client can provide us with a progress token to report progress with.

Since we cannot report diagnostics before responding to initialize, we leave that in the initialized notification handler.

@fwcd fwcd merged commit a0b361e into main Oct 14, 2024
3 checks passed
@fwcd fwcd deleted the initialize-handling branch October 14, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant