Feature: Add support for t.ly URL shortener service#152
Conversation
fwenzel
left a comment
fwenzel
left a comment
There was a problem hiding this comment.
I like the change - but two things:
- I don't really want 4-space indentation as part of this change
- and it makes the change much more significant than simply adding t.ly
If your PR had two separate commits in it, I would simply cherry-pick the code change for t.ly but it does not so I am not sure how to pull only those changes :(
There was a problem hiding this comment.
Pull request overview
This PR adds support for the t.ly URL shortener service as a new option alongside existing services like bit.ly, cutt.ly, and kutt.it. Additionally, it includes locale message fixes for Chinese translations and formatting improvements via Prettier.
- Implements t.ly shortener with API key authentication and optional custom domain support
- Updates localization files (English, German, Simplified Chinese, Traditional Chinese) with t.ly-related messages
- Fixes JSON formatting issues in locale files (whitespace alignment)
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/shortener.js | Adds t.ly service configuration with API integration following the pattern of existing authenticated services; includes Prettier formatting changes throughout |
| src/data/js/options.js | Adds t.ly API key and domain options; includes t.ly in the service list for UI visibility |
| src/data/html/options.html | Adds UI elements for t.ly configuration including API key input and custom domain field with appropriate help links |
| src/_locales/en/messages.json | Adds English locale messages for t.ly service configuration; fixes JSON formatting |
| src/_locales/de/messages.json | Adds German locale messages for t.ly service configuration; fixes JSON formatting |
| src/_locales/zh_CN/messages.json | Adds Simplified Chinese locale messages for t.ly service and improves existing translations; fixes JSON formatting |
| src/_locales/zh_TW/messages.json | Adds Traditional Chinese locale messages for t.ly service and improves existing translations; fixes JSON formatting |
| .gitignore | Adds entries for personal development files (Copilot instructions, VS Code config, pnpm lock file) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
I modified the entire format and added the prettier rule file to help standard the formatting. |
Feature: Add t.ly URL Shortener Support
This Pull Request introduces the
t.lyshortener service as an option for generating short URLs.t.lyt.lyis a reliable, fast, and free shortener service that provides another good option for users of this extension.Bug Fix / Maintenance
Note for Maintainer (Code Formatting)
I use the Prettier code formatter locally, and I inadvertently formatted the code in some files (potentially due to running an auto-format on save).
I sincerely apologise for the unnecessary diff in the PR history. The core changes are strictly for the
t.lyfeature and the locale fixes.If the formatting changes are not desired, please let me know, and I can try to revert them or squash the relevant commits before merging.