Skip to content

Comments

feat: support macos log#2235

Merged
fzyzcjy merged 2 commits intofzyzcjy:masterfrom
wxitcode:master
Aug 11, 2024
Merged

feat: support macos log#2235
fzyzcjy merged 2 commits intofzyzcjy:masterfrom
wxitcode:master

Conversation

@wxitcode
Copy link
Contributor

@wxitcode wxitcode commented Aug 8, 2024

Changes

Support logging on macOS in the same way as iOS.

Logs can be viewed through Instruments and Console.

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Aug 9, 2024

Good job! After fixing CI (maybe applying the suggestion above first and see what is going on) ready to merge it

@codecov
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (42f8102) to head (e2da89a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2235   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files         488      488           
  Lines       20184    20184           
=======================================
  Hits        19995    19995           
  Misses        189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wxitcode
Copy link
Contributor Author

wxitcode commented Aug 9, 2024

ci failed just wait for new version rust nightly. rust-lang/cargo#14370

error: "/home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/Cargo.lock" does not exist, unable to build with the standard library, try:
        rustup component add rust-src --toolchain nightly-x86_64-unknown-linux-gnu

@fzyzcjy
Copy link
Owner

fzyzcjy commented Aug 9, 2024

Sure, then just wait a bit!

@fzyzcjy fzyzcjy merged commit d3e1393 into fzyzcjy:master Aug 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants