Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing QRCodeGraphics to generate a valid QRCode on iOS #93

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Fixing QRCodeGraphics to generate a valid QRCode on iOS #93

merged 3 commits into from
Nov 27, 2023

Conversation

ruicanas
Copy link
Contributor

@ruicanas ruicanas commented Nov 25, 2023 •
edited
Loading

This PR is associated to #92.

Changes:

  1. Added 1 more available format on iOS
  2. In QRCodeGraphics, getBytes() is returning valid data instead of an empty ByteArray
  3. In QRCodeGraphics, thickness is now being used to give the proper thickness for rectangles (drawRect())
  4. I added a useful converter that transforms NSData into ByteArray

@g0dkar
Copy link
Owner

g0dkar commented Nov 26, 2023

Just to keep you updated, I'll merge it with the minor suggestion I've made on monday :)

@g0dkar g0dkar merged commit 3dfcd6e into g0dkar:main Nov 27, 2023
1 check passed
@ruicanas ruicanas deleted the fix-qrcodegraphics-get-bytes-for-ios branch December 3, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g0dkar g0dkar g0dkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruicanas @g0dkar