Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Briefly describe what this PR does and why it's needed.
Related Issue
Closes #<issue_number>
Related to #<issue_number>
Specification Link
If this implements a feature from a
.vibeespecification, link it here:Spec:
specs/tri/<feature_name>.vibeeGenerated Code:
var/trinity/output/<feature_name>.zigChanges Made
Files Changed
src/file1.zig- Description of changesspecs/tri/feature.vibee- Updated specificationvar/trinity/output/feature.zig- Generated code (DO NOT EDIT MANUALLY)docs/feature.md- Documentation updatesGolden Chain Checklist
All PRs MUST follow the Golden Chain workflow:
.vibeespecification before writing codezig build vibee -- gen specs/tri/<feature>.vibeezig build testpasses (100% coverage for new code)zig fmt src/applied (code follows style guide).html,.css,.js,.ts,.jsx,.tsxfiles (use VIBEE gen)var/trinity/output/Testing Checklist
zig buildcompletes without errorszig test src/<module>.zigpasseszig build testpasses all teststri verify(Links 7-11: tests + benchmarks)docs/docs/if neededTest Results
Performance Impact
Benchmarks (if applicable):
zig build bench # Paste results hereBreaking Changes
Does this PR introduce breaking changes?
If Yes, describe breaking changes:
🔥 TOXIC VERDICT
CRITICAL: Perform honest self-assessment of this PR before requesting review.
What Works
What Doesn't Work
Tech Debt
Known Issues
Metrics
Toxic Verdict
Overall Assessment: [APPROVE / REQUEST CHANGES / REJECT]
Reasoning:
Provide honest, critical assessment. If this PR should be blocked or rewritten, say so.
Self-Score: __/10
🌳 TECH TREE Options
Based on this PR, propose 3 next steps for the project's evolution:
Option 1: [Name]
Option 2: [Name]
Option 3: [Name]
Recommendation: Option [X] is the best next step because ...
Sacred Mathematics (if applicable)
If this PR involves sacred mathematics, golden ratio, or ternary computing:
Deployment Notes
Deployment Steps:
cd website && npx vite buildcd docs && npm run buildReviewer Notes
Any specific areas you'd like reviewers to focus on:
Checklist
docs/docs/research/(if applicable)