Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change beaconFilterinTermsResults type to enum #90

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

costero-e
Copy link
Collaborator

This PR is for the issue opened by Sergi (I can't tag Sergi) here #77 . Please @mrueda and @redmitry, can you review this PR? Thank you.

Copy link
Collaborator

@redmitry redmitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when type is "ontology", "id" prefix should be used to find the ontology in resources.

@jrambla
Copy link
Contributor

jrambla commented Jan 9, 2024

This PR is a fix, however it is breaking the specification and potentially some implementations.
DO we have a policy for such cases?

Copy link
Member

@mbaudis mbaudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO good & doesn't break implementations since the values stay string etc. (but possibly breaks verifiers if not updated).
Small change suggested: Style-wise we always should do plural examples: [].

@jrambla
Copy link
Contributor

jrambla commented Jan 11, 2024

@mbaudis, I believe we must consider a change as breaking if the current implementations are compliant with the current spec, BUT the change on the spec makes them not compliant anymore, Which is this case, e.g. teh Beacon Network will reject the filteringTerms endpoint response as invalid ;-)

@mbaudis
Copy link
Member

mbaudis commented Jan 11, 2024

@jrambla Sure, understood. But I guess the amount of aggregators, and esp. of the ones doing such checks, outside of Beacon core developer control are ... rather small. But anyway a change that can wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants