-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change beaconFilteringTermsResults type to enum #90
base: schema-urgent-fixes
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when type is "ontology", "id" prefix should be used to find the ontology in resources.
This PR is a fix, however it is breaking the specification and potentially some implementations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO good & doesn't break implementations since the values stay string etc. (but possibly breaks verifiers if not updated).
Small change suggested: Style-wise we always should do plural examples: []
.
@mbaudis, I believe we must consider a change as breaking if the current implementations are compliant with the current spec, BUT the change on the spec makes them not compliant anymore, Which is this case, e.g. teh Beacon Network will reject the filteringTerms endpoint response as invalid ;-) |
@jrambla Sure, understood. But I guess the amount of aggregators, and esp. of the ones doing such checks, outside of Beacon core developer control are ... rather small. But anyway a change that can wait. |
This PR is for the issue opened by Sergi (I can't tag Sergi) here #77 . Please @mrueda and @redmitry, can you review this PR? Thank you.