sync upstream desktop shell env fix and bug report attachment support#29
Merged
gabrielMalonso merged 4 commits intomainfrom Mar 16, 2026
Merged
sync upstream desktop shell env fix and bug report attachment support#29gabrielMalonso merged 4 commits intomainfrom
gabrielMalonso merged 4 commits intomainfrom
Conversation
…otgg#972) Co-authored-by: Julius Marminge <julius0216@outlook.com>
- update upstream-sync skill to read/write `.claude/upstream-sync.md` - add `.claude/upstream-sync.md` with current sync status and history
github-actions
bot
added
size:L
- Create .claude/upstream-sync.md documenting all synced upstream commits - Document fork-exclusive reimplementations (ChatView split pingdotgg#860, sub-threads, etc.) - Update skill path from .context/ to .claude/ - Fix oxfmt formatting on markdown tables Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t3code/upstream-syncintomainlineage, including the new.claude/upstream-sync.mdchangelog tracking.fixPath()withsyncShellEnvironment()to hydratePATHand backfill missingSSH_AUTH_SOCKfrom login shell on macOS while preserving inherited values.readEnvironmentFromLoginShell()and marker-based multi-variable extraction/validation.Testing
Not run(PR content generated from provided commit/diff context).apps/desktop/src/syncShellEnvironment.test.tsfor macOS/non-macOS andSSH_AUTH_SOCKprecedence cases.packages/shared/src/shell.test.tsfor multi-variable login-shell extraction, missing values, and whitespace preservation.