Skip to content

[codex] Add hybrid skill discovery and composer UX#36

Merged
gabrielMalonso merged 6 commits intomainfrom
feat/hybrid-skills
Apr 10, 2026
Merged

[codex] Add hybrid skill discovery and composer UX#36
gabrielMalonso merged 6 commits intomainfrom
feat/hybrid-skills

Conversation

@gabrielMalonso
Copy link
Copy Markdown
Owner

O que mudou

  • adiciona discovery híbrido de skills/comandos por provider para Codex e Claude Code
  • suporta skills globais do Codex em ~/.codex/skills/.system e também caminhos extras em ~/.agents/skills
  • envia skills do Codex de forma estruturada no turn/start, em vez de depender só de texto no prompt
  • melhora o menu do composer com mais espaço para o nome, tooltip e descrição mais longa

Por que mudou

O fluxo anterior tinha três problemas reais:

  1. o Codex só encontrava parte das skills disponíveis
  2. a UI do composer escondia demais os nomes/descrições das skills
  3. a skill do Codex podia aparecer no menu sem atravessar o backend do jeito certo

Impacto

  • Codex agora lista melhor skills locais e globais
  • Claude Code continua funcionando com discovery separado e sem misturar semântica de provider
  • o menu de skills ficou mais legível e com tooltip útil em hover

Validação

  • bun fmt
  • bun lint
  • bun typecheck
  • testes focados em contracts, web parser/menu e server discovery/codex forwarding

Observações

  • o bun lint continua com um warning preexistente em apps/web/src/environments/runtime/catalog.test.ts
  • o PR foi aberto como draft por segurança

- Discover project and user skills for Codex and Claude
- Allow composer skill tokens to flow through orchestration and turns
- Make auth migrations self-healing on existing local databases
- Increase command description truncation on the server
- Add hover tooltips for skill entries in the composer menu
@github-actions github-actions bot added size:XXL 1,000+ changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 10, 2026
- Derive and dedupe skill selections from discovered Codex commands
- Keep composer cursor and mention handling aligned with skill tokens
- Normalize workspace paths before listing provider commands over WS
- Replace skill-specific composer chips with generic custom tokens
- Move Codex skill menu/selection logic into the chat skill extension
- Move mention and custom token Lexical nodes into a shared module
- Keep ComposerPromptEditor focused on composer behavior
@gabrielMalonso gabrielMalonso marked this pull request as ready for review April 10, 2026 18:04
@gabrielMalonso gabrielMalonso merged commit 6c1902b into main Apr 10, 2026
6 of 7 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d8a0bfba5b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1570 to +1572
promptRef.current = next.text;
setPrompt(next.text);
setComposerCursor(nextCursor);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Route skill inserts through pending-answer updater

When a pending user-input question is active, composer edits are supposed to flow through onChangeActivePendingUserInputCustomAnswer (as done in applyPromptReplacement) so the response payload matches what the user sees. The skill-selection branch bypasses that path and writes directly via setPrompt, so picking a $skill suggestion during pending-question mode can update the editor text but not the pending answer state that is ultimately submitted.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant