test-pr - #5
Open
TeresaHo wants to merge 1 commit into
Open
Conversation
gabyvon725
reviewed
Mar 15, 2018
| import sys | ||
| from datetime import datetime | ||
|
|
||
| import cv2 |
gabyvon725
reviewed
Mar 15, 2018
|
|
||
|
|
||
| # Read until video is completed | ||
| while(self.cap.isOpened()): |
gabyvon725
reviewed
Mar 15, 2018
| # Read until video is completed | ||
| while(self.cap.isOpened()): | ||
| ret, frame = self.cap.read() | ||
| if ret == True: |
Owner
There was a problem hiding this comment.
Line 35 可以寫成 if ret:，因為通常較少用 == 來比較物件跟 True/False boolean
gabyvon725
reviewed
Mar 15, 2018
| cv2.imshow('Frame',frame) | ||
| self.frames.append(frame_r) | ||
| if cv2.waitKey(25) & 0xFF == ord('q'): | ||
| break |
Owner
There was a problem hiding this comment.
Line 39 40 這邊可以不寫哦。 因為目的就是要讓它處理完，不存在中途需要quit的問題。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done by 何家蓁