fix: disable more of the broken rules

gajus · May 17, 2024 · eb3448d · eb3448d
1 parent 1f7aad6
commit eb3448d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 13 deletions.
diff --git a/configurations/canonical.js b/configurations/canonical.js
@@ -31,12 +31,13 @@ const importRules = {
   'import/no-cycle': 2,
   'import/no-default-export': 0,
   'import/no-deprecated': 1,
-  'import/no-duplicates': [
-    2,
-    {
-      'prefer-inline': true,
-    },
-  ],
+  // TODO broke after ESLint upgrade to v9
+  // 'import/no-duplicates': [
+  //   2,
+  //   {
+  //     'prefer-inline': true,
+  //   },
+  // ],
   'import/no-dynamic-require': 2,
   'import/no-extraneous-dependencies': [
     2,
@@ -48,9 +49,10 @@ const importRules = {
   ],
   'import/no-import-module-exports': 0,
   'import/no-internal-modules': 0,
-  'import/no-mutable-exports': 2,
-  'import/no-named-as-default': 2,
-  'import/no-named-as-default-member': 2,
+  // TODO broke after ESLint upgrade to v9
+  // 'import/no-mutable-exports': 2,
+  // 'import/no-named-as-default': 2,
+  // 'import/no-named-as-default-member': 2,
   'import/no-named-default': 2,
   'import/no-named-export': 0,
   'import/no-namespace': 0,
@@ -298,7 +300,7 @@ module.exports.recommended = {
       },
     ],
     'canonical/import-specifier-newline': 2,
-    'canonical/no-import-namespace-destructure': 2,
+    // 'canonical/no-import-namespace-destructure': 2,
     'canonical/no-restricted-strings': 0,
     'canonical/no-use-extend-native': 2,
     'canonical/sort-destructure-keys': 2,

diff --git a/configurations/react.js b/configurations/react.js
@@ -8,7 +8,7 @@ module.exports.recommended = {
     // TODO broke after upgrading to ESLint v9
     // 'canonical/sort-react-dependencies': 2,
     'react/boolean-prop-naming': 0,
-    'react/button-has-type': 2,
+    // 'react/button-has-type': 2,
     // TODO broke after upgrading to ESLint v9
     // 'react/default-props-match-prop-types': 2,
     'react/destructuring-assignment': 0,
@@ -27,7 +27,7 @@ module.exports.recommended = {
     //   },
     // ],
     // 'react/hook-use-state': 2,
-    'react/iframe-missing-sandbox': 2,
+    // 'react/iframe-missing-sandbox': 2,
     'react/jsx-boolean-value': [2, 'never'],
     'react/jsx-child-element-spacing': 0,
     'react/jsx-closing-bracket-location': [2, 'line-aligned'],
@@ -151,7 +151,7 @@ module.exports.recommended = {
     // TODO broke after upgrading to ESLint v9
     // 'react/no-array-index-key': 2,
     // 'react/no-arrow-function-lifecycle': 2,
-    'react/no-children-prop': 2,
+    // 'react/no-children-prop': 2,
     'react/no-danger': 2,
     'react/no-danger-with-children': 2,
     'react/no-deprecated': 2,
@@ -195,7 +195,9 @@ module.exports.recommended = {
     'react/react-in-jsx-scope': 0,
     'react/require-default-props': 0,
     'react/require-optimization': 0,
+    // TODO broke after upgrading to ESLint v9
     // 'react/require-render-return': 2,
+    // TODO broke after upgrading to ESLint v9
     'react/self-closing-comp': 2,
     // 'react/sort-comp': 2,
     'react/sort-default-props': 2,