Skip to content

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp commented Sep 17, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Summary by CodeRabbit

  • Chores
    • Broadened compatibility with @galacean/engine (and @galacean/engine-ui / @galacean/engine-xr) by relaxing version requirements to >=1.6.0-0 across packages.
    • Updated dependency resolution to accept newer engine versions without requiring package updates, improving flexibility for consumers.

Copy link

coderabbitai bot commented Sep 17, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Relaxed version constraints for @galacean/engine (and related packages) across multiple package.json files, switching from ^1.6.0-alpha.2 to >=1.6.0-0. Updated root overrides, various package peerDependencies, one direct dependency, and tests dependency. No source code or control-flow changes.

Changes

Cohort / File(s) Summary
Root override
package.json
pnpm overrides: @galacean/engine changed from ^1.6.0-alpha.2 to >=1.6.0-0.
PeerDeps: engine
packages/auxiliary-lines/package.json, packages/controls/package.json, packages/custom-gltf-parser/package.json, packages/custom-material/package.json, packages/dynamic-bone/package.json, packages/framebuffer-picker/package.json, packages/geometry-sketch/package.json, packages/input-logger/package.json, packages/lines/package.json, packages/navigation-gizmo/package.json, packages/outline/package.json, packages/skeleton-viewer/package.json, packages/stats/package.json, packages/tween/package.json, packages/way-point/package.json
peerDependencies["@galacean/engine"]: ^1.6.0-alpha.2>=1.6.0-0.
PeerDeps: engine + engine-ui
packages/gizmo/package.json
peerDependencies["@galacean/engine"] and ["@galacean/engine-ui"]: ^1.6.0-alpha.2>=1.6.0-0.
PeerDeps: engine + engine-xr
packages/xr/package.json
peerDependencies["@galacean/engine"] and ["@galacean/engine-xr"]: ^1.6.0-alpha.2>=1.6.0-0.
Deps: engine
packages/draco/package.json
dependencies["@galacean/engine"]: ^1.6.0-alpha.2>=1.6.0-0.
Tests deps
tests/package.json
dependencies["@galacean/engine"]: ^1.6.0-alpha.2>=1.6.0-0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Update dep version #343 — Prior update changing @galacean/engine from ^1.5.0 to ^1.6.0-alpha.2 across package.json files; this PR follows by relaxing to >=1.6.0-0.

Poem

I twitch my whiskers, bump the tag,
From alpha pins to open flag.
Semvers hop where ranges flow,
Greater-equal, on we go!
Carrot-shaped carets fade from sight—
Boundless bounds, dependencies light. 🥕✨

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4584087 and 6294761.

📒 Files selected for processing (20)
  • package.json (1 hunks)
  • packages/auxiliary-lines/package.json (1 hunks)
  • packages/controls/package.json (1 hunks)
  • packages/custom-gltf-parser/package.json (1 hunks)
  • packages/custom-material/package.json (1 hunks)
  • packages/draco/package.json (1 hunks)
  • packages/dynamic-bone/package.json (1 hunks)
  • packages/framebuffer-picker/package.json (1 hunks)
  • packages/geometry-sketch/package.json (1 hunks)
  • packages/gizmo/package.json (1 hunks)
  • packages/input-logger/package.json (1 hunks)
  • packages/lines/package.json (1 hunks)
  • packages/navigation-gizmo/package.json (1 hunks)
  • packages/outline/package.json (1 hunks)
  • packages/skeleton-viewer/package.json (1 hunks)
  • packages/stats/package.json (1 hunks)
  • packages/tween/package.json (1 hunks)
  • packages/way-point/package.json (1 hunks)
  • packages/xr/package.json (1 hunks)
  • tests/package.json (1 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cptbtptpbcptdtptp cptbtptpbcptdtptp merged commit 585e404 into galacean:main Sep 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant