-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust circuit breaker benchmarks #622
Conversation
Crate versions that have been updated:
Runtime version has not been increased. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #622 +/- ##
==========================================
+ Coverage 64.63% 64.66% +0.03%
==========================================
Files 130 130
Lines 9450 9459 +9
==========================================
+ Hits 6108 6117 +9
Misses 3342 3342
☔ View full report in Codecov by Sentry. |
It looks like the weight was wrong. I checked other benchmarks/weights and 1 nanosecond ~= 1_000 weight. So the weight should be correct now. |
Processed TODOs to split up on_initialize benchmarking into trade and liquidity separately
NOTE: The bench weight result of
on_finalize
changed a lot, not sure where it comes from as it was benchmarked now on the reference machine.