feat: stableswap gradual amplification change #629
Conversation
|
Crate versions that have been updated:
Runtime version has not been increased. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #629 +/- ##
==========================================
+ Coverage 64.94% 65.17% +0.22%
==========================================
Files 131 131
Lines 9559 9647 +88
==========================================
+ Hits 6208 6287 +79
- Misses 3351 3360 +9
☔ View full report in Codecov by Sentry. |
| ); | ||
| ensure!( | ||
| pool.final_amplification.get() != final_amplification, | ||
| Error::<T>::SameAmplification |
There was a problem hiding this comment.
what if you want to speed up or slow down ramp up? this check seems not very effective as it could be bypassed by just changing final amp by 1
There was a problem hiding this comment.
this just ensures that you dont set the same value as there is now as it does not make any change
There was a problem hiding this comment.
you can still change it however with the same final amp, as you can set different end block therefore slow down or hasten the change
There was a problem hiding this comment.
yes. now it is different - this was a case when you had to wait for previous change to finish.
now it makes sense to ensure that the new final amplification != initial ampfliciation, isnt it ?
This PR introduces gradual change of amplification for stableswap pool.