Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Opengov #848

Open
wants to merge 85 commits into
base: master
Choose a base branch
from
Open

feat: Opengov #848

wants to merge 85 commits into from

Conversation

vgantchev
Copy link
Contributor

@vgantchev vgantchev commented Jun 22, 2024

This PR adds OpenGov which for some time will run in parallel to gov v1.

TODO:

  • Tracks
  • Replace runtime origins
  • Exclude Referenda from CallFilter
  • Hook up staking
  • make it possible for Treasurer origin to control the Treasury account
  • rebench referenda, whitelist and conviction-voting ?

Copy link

github-actions bot commented Jun 22, 2024

New crates:

  • pallet-conviction-voting: v28.0.0

Crate versions that have been updated:

  • runtime-integration-tests: v1.23.7 -> v1.23.8
  • pallet-circuit-breaker: v1.1.26 -> v1.1.27
  • pallet-dca: v1.6.1 -> v1.6.2
  • pallet-omnipool: v4.3.4 -> v4.4.0
  • pallet-omnipool-liquidity-mining: v2.2.1 -> v2.2.2
  • pallet-otc: v2.0.2 -> v2.0.3
  • pallet-otc-settlements: v1.0.4 -> v1.0.5
  • pallet-route-executor: v2.6.1 -> v2.6.2
  • pallet-stableswap: v3.6.5 -> v3.7.0
  • pallet-staking: v3.1.2 -> v4.0.0
  • pallet-transaction-pause: v1.0.4 -> v1.1.0
  • hydradx-adapters: v1.3.6 -> v1.3.7
  • hydradx-runtime: v261.0.0 -> v262.0.0

Runtime version has been increased.

@vgantchev
Copy link
Contributor Author

vgantchev commented Aug 13, 2024

@mrq1911 thank you for reviewing

most of your comments on origins have been resolved in 75c1899 and i have left comments on places where i don't agree or have questions

Copy link
Member

@mrq1911 mrq1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for the #891 to be merged

Copy link
Contributor

@jak-pan jak-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the conviction voting pallet diff and it seems like we are not firing events anymore. Is this intentional?

name: "root",
max_deciding: 1,
decision_deposit: 5_000_000 * UNITS,
prepare_period: 24 * HOURS,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need more reasonable periods if we want to use this for runtime upgrades, currently only prepare + confirm + enactment will take 3 days

not even sure why is any prepare period necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants