Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove XCM pallet from call filter #885

Closed
wants to merge 3 commits into from

Conversation

green-jay
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Aug 5, 2024

Crate versions that have been updated:

  • runtime-integration-tests: v1.23.1 -> v1.23.2
  • hydradx-runtime: v254.0.0 -> v255.0.1

Runtime version has been increased.

@green-jay green-jay requested review from jak-pan and Roznovjak August 6, 2024 06:36
@@ -1,6 +1,6 @@
[package]
name = "hydradx-runtime"
version = "254.0.0"
version = "255.0.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch bump as well ? :)

@mrq1911 mrq1911 changed the title feat: Remove XCM pallet from call filter feat: remove XCM pallet from call filter to support snowfork Aug 9, 2024
@mrq1911
Copy link
Member

mrq1911 commented Aug 9, 2024

  • can we wait for 1.11
  • are the benchmarks correct

@green-jay
Copy link
Contributor Author

max_weight: Weight::zero(),
});

assert!(!hydradx_runtime::CallFilter::contains(&call));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about keeping the test, but flipping the boolean in the assertion?

@mrq1911 mrq1911 marked this pull request as draft August 23, 2024 13:43
@mrq1911
Copy link
Member

mrq1911 commented Aug 23, 2024

  • enable AH as reserve

@green-jay green-jay changed the title feat: remove XCM pallet from call filter to support snowfork feat: remove XCM pallet from call filter Aug 27, 2024
@mrq1911
Copy link
Member

mrq1911 commented Aug 30, 2024

blocked by #867

@green-jay
Copy link
Contributor Author

superseeded by #895

@green-jay green-jay closed this Sep 18, 2024
@jak-pan jak-pan mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants