Skip to content

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Sep 26, 2025

nodeenv has various issues like ekalinin/nodeenv#388, and fetching the node installation via pypi seems easier for packaged galaxy as well.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo
Copy link
Member

nsoranzo commented Sep 26, 2025

Should we drop the actions/setup-node@v5 steps in CI workflows?

If we do, then we can also drop the client/.node_version file and relax nodejs-wheel==22.13.0 to ==22 in both packages/app/setup.cfg and pyproject.toml . This way we can have weekly nodejs minor-version updates handled by uv.

@mvdbeek
Copy link
Member Author

mvdbeek commented Sep 27, 2025

We still use .node-version in some of the actions that we can't remove, but I think removing it wherever we do install python dependencies is a good idea.

@mvdbeek mvdbeek modified the milestones: 26.0, 25.1 Sep 27, 2025
Where we still use the action we don't install python dependencies.
Co-authored-by: Nicola Soranzo <[email protected]>
@nsoranzo nsoranzo merged commit 2f570c4 into galaxyproject:dev Sep 29, 2025
53 of 56 checks passed
@nsoranzo nsoranzo deleted the nodejs-wheel branch September 29, 2025 22:07
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants