Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDFReader hold resource issue #276

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

PDFReader hold resource issue #276

wants to merge 2 commits into from

Conversation

hl-a-k
Copy link

@hl-a-k hl-a-k commented May 4, 2018

sovled PDFReader hold resource issue.
Add end method to PDFReaderDriver

@fxpopp
Copy link

fxpopp commented May 4, 2018

Could you please specify how you invoce the end methode using node.js

@hl-a-k
Copy link
Author

hl-a-k commented May 4, 2018 via email

@fxpopp
Copy link

fxpopp commented May 4, 2018

Thank you very much!
I use npm - could you help me with npm, too?
How do I use/rebuild your hummus?

@galkahana
Copy link
Owner

that would be problematic if you delete streams that you dont own.

anyways, can always either:

  1. scope out pdfreader
  2. use PDFRStreamForFile as source for pdfReader, which you can then close with its own method

@Frank683
Copy link

anyways, can always either:

  1. scope out pdfreader

Could you please explain what you mean by scope out?
Setting the pdfreader to undefined doesn't do the thing, so what else could I do?

Using the PDFRStreamForFile is not an option because it's really really slow compared to directly passing a file to hummus.createReader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants