Reworking rng #426
Draft
Reworking rng #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- very incomplete but the missing parts are documented in the comments
- creates nextInt(int) and nextInt(int, int) methods in IGamaRNG - removes unused nextInt() to avoid confusion - some inlined comments about future work to come
…hod with the call of nextInt(int)
| for (long i = 0; i < usage; i++) { nextInt(); } | ||
| //TODO: If nextInt(nb) with nb a power of 2 we draw less than if not | ||
| // but this doesn't reflect on the rng_usage | ||
| for (long i = 0; i < usage; i++) { nextInt(32); } |
There was a problem hiding this comment.
It is poorly explained in the comment above: calling it with a number of bit that is not a power of 2 results in more than one draw which is not what we want to achieve here.
See the implementation of nextInt(int) called by in Random.class itself called by GamaRNG:
There's a TODO because I do not like the idea of having to take into account the specificities of certain implementation and I'd prefer to have a nextState function or something similar instead.
…e usage is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress to answer #419 by using more appropriate methods to draw random numbers in certain cases.
Also will tackle the lack of flexibility of setting the variable
rng_usage.And at the same time will provide a comprehensive unit test file to cover the use of random operators in gama