-
Notifications
You must be signed in to change notification settings - Fork 16
[gaml] introduce user defined types #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lesquoyb
wants to merge
15
commits into
main
Choose a base branch
from
PR-data-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be cautious, not sure what I'm doing here
- finish creating types and methods to handle data_type in the grammar and fix bugs - add the new types to the model's types - fill the new types with the variables defined inside - replace placeholder code by notimplementedexception to be sure it'll be implemented
This commit refactors and extends the handling of user-defined data types in the GAMA platform. It introduces and documents the GamaData and GamaDataType classes, updates the ModelFactory to properly parent and manage data types, and adjusts the grammar and parser to recognize data types as first-class type definitions. The commit also improves error handling and code documentation throughout the data type management workflow.
…into PR-data-type
Improves the management of DataTypeDescription in ModelDescription and TypeDescription by moving addChild logic from TypeDescription to DataTypeDescription, ensuring data types are added correctly. Updates ModelFactory to avoid complementing data nodes directly and clarifies JavaDoc comments. Also updates copyright and license headers.
…into PR-data-type
- broke some part of built-in skills (like moving) - starts separating user defined skills and built-in ones (to be completed) - enable declaring skills in gaml, with the name being recognised in the skills facet of species - content of the user defined skills is not imported in agents yet - fixes some bugs with data_type - move data_type methods to more appropriate sections of the code - some more renaming for better understanding -
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a work in progress
list of goals to attain to merge it to main
create
Problems and bugs so far
name
facet for now