simplify proto types

gamercade-io · Apr 20, 2024 · 23ec254 · 23ec254
1 parent 68d06e8
commit 23ec254
Show file tree

Hide file tree

Showing 6 changed files with 416 additions and 534 deletions.
diff --git a/gamercade_interface/proto/game.proto b/gamercade_interface/proto/game.proto
@@ -5,13 +5,13 @@ import "common.proto";
 package game;
 
 service GameService {
-    rpc GetSingleGameInfo(GameInfoRequest) returns (GameInfoBasic);
-    rpc GetMultipleGamesInfo(MultipleGamesInfoRequest) returns (MultipleGamesInfoResponse);
-    rpc GetGameDetailedInfo(GameInfoRequest) returns (GameInfoDetailed);
+    rpc GetSingleGameInfo(SingleGameRequest) returns (GameInfoBasic);
+    rpc GetMultipleGamesInfo(MultipleGamesRequest) returns (MultipleGamesInfoResponse);
+    rpc GetGameDetailedInfo(SingleGameRequest) returns (GameInfoDetailed);
 
     rpc CreateGame(UpdateGameRequest) returns (GameInfoBasic);
     rpc UpdateGame(UpdateGameRequest) returns (GameInfoBasic);
-    rpc DeleteGame(DeleteGameRequest) returns (common.Empty);
+    rpc DeleteGame(SingleGameRequest) returns (common.Empty);
 }
 
 message UpdateGameRequest {
@@ -21,11 +21,11 @@ message UpdateGameRequest {
     optional string long_description = 4;
 }
 
-message GameInfoRequest {
+message SingleGameRequest {
     sfixed64 game_id = 1;
 }
 
-message MultipleGamesInfoRequest {
+message MultipleGamesRequest {
     repeated sfixed64 game_ids = 1;
 }
 
@@ -51,7 +51,3 @@ message GameInfoDetailed {
 message Author {
     sfixed64 user_id = 1;
 }
-
-message DeleteGameRequest {
-    sfixed64 game_id = 1;
-}
diff --git a/gamercade_interface/proto/review.proto b/gamercade_interface/proto/review.proto
@@ -1,32 +1,16 @@
 syntax = "proto3";
 
 import "common.proto";
+import "game.proto";
 
-package game;
+package review;
 
 service ReviewService {
     rpc ReviewGame(ReviewGameRequest) returns (common.Empty);
-    rpc DeleteReview(SingleGameRequest) returns (common.Empty);
-    rpc GetGameReviews(SingleGameRequest) returns (GameReviews);
+    rpc DeleteReview(game.SingleGameRequest) returns (common.Empty);
 }
 
 message ReviewGameRequest {
     sfixed64 game_id = 1;
-    int32 rating = 2;
-    string comments = 3;
-}
-
-message SingleGameRequest {
-    sfixed64 game_id = 1;
-}
-
-message GameReviews {
-    repeated GameReviewEntry reviews = 1;
-}
-
-message GameReviewEntry {
-    sfixed64 user_id = 1;
-    int32 rating = 2;
-    string comments = 3;
-    int64 review_date_s = 4;
+    bool rating = 2;
 }
diff --git a/gamercade_interface/proto/tag.proto b/gamercade_interface/proto/tag.proto
@@ -10,8 +10,9 @@ service TagService {
 }
 
 message AdjustGameTagRequest {
-    int32 tag_id = 1;
-    bool set_to = 2;
+    sfixed64 game_id = 1;
+    int32 tag_id = 2;
+    bool set_to = 3;
 }
 
 message AdjustGameTagResponse {