-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate and push report #17
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments for now (I haven't looked in detail yet). I have pushed empty branches gh-pages
and data
to this repo.
The references to FriedrichRober/integration
should probably be removed.
.github/workflows/pkg-tests.yml
Outdated
report: | ||
name: "Report" | ||
needs: individual-package | ||
if: always() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, at least once we have finished testing, we only want to generate reports when we have run this workflow with all packages.
if: always() | |
if: ${{ always() && github.event.inputs.packages == '' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also save those in a different location, for example the suggested manual
folder that could contain all reports created by a workflow dispatch.
Co-authored-by: Lucas Wollenhaupt <[email protected]>
❗ Before merge, we need to create a
data
andgh-pages
branch. ❗Current Procedure:
latest
, which is a symlink to the latest report directorylatest
symlinkREADME.md
(via creating a request toshields.io
, a free service that generates and provides this badge)data
branch under hashgh-pages
that is used inREADME.md
for referencing the latest report (it seems to me that symlinks cannot be redirected natively in github markdown nor github pages; i decided it is better to update thegh-pages
branch instead of theREADME.md
on themain
branch each time a report is created.)Missing Features:
gap_build_version
in the docker does not contain the hash to the commit when it was builtpkg-tests.yml
uses standard and minimal setup, but we only store the state of minimal setuppkg-tests.yml
github.event_name
:daily
contains daily reports fromschedule
triggerhash
contains reports frompull request
trigger or acomment
trigger as in Juliamanual
contains reports fromworkflow dispatch
triggerlatest
symlink to latest report in dailyhash
compare against latest hash in history that is contained inhash
FriedrichRober/integration
should be removed.