Repository navigation
Use TrivialGroup instead of SmallGroup(1,1) - #112
Merged
Merged
Conversation
Avoids requiring the SmallGrp package for the trivial group. See gap-system/gap#2434 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
=======================================
Coverage 84.36% 84.36%
=======================================
Files 11 11
Lines 5008 5008
=======================================
Hits 4225 4225
Misses 783 783
🚀 New features to boost your workflow:
|
olexandr-konovalov
approved these changes
Aug 16, 2026
olexandr-konovalov
left a comment
olexandr-konovalov
left a comment
Member
There was a problem hiding this comment.
This is @drallenherman's code. Since TrivialGroup with no arguments returns TrivialGroupCons( IsPcGroup ), this sounds harmless to me.
Member
|
The changed line is covered by tests. Happy to merge this and I will now make a new release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids requiring the SmallGrp package for the trivial group.
See gap-system/gap#2434
Co-Authored-By: Claude Opus 5 noreply@anthropic.com