Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base component descriptor workflow #1117

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Base component descriptor workflow #1117

merged 4 commits into from
Jan 13, 2025

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Jan 10, 2025

Release note:

implement a reusable workflow for conveniently generating `base ocm-component-descriptors`

@ccwienk ccwienk requested review from 8R0WNI3 and zkdev as code owners January 10, 2025 15:43
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jan 10, 2025
@ccwienk ccwienk force-pushed the base-component-descriptor-workflow branch from 74bee70 to bb09e40 Compare January 10, 2025 15:50
@ccwienk ccwienk force-pushed the base-component-descriptor-workflow branch from bb09e40 to e77fb98 Compare January 10, 2025 16:00
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jan 11, 2025
8R0WNI3
8R0WNI3 reviewed Jan 13, 2025
View reviewed changes
ocm/__main__.py Outdated Show resolved Hide resolved
ocm/__main__.py Outdated Show resolved Hide resolved
.github/workflows/base-component-descriptor.yaml Outdated Show resolved Hide resolved
8R0WNI3
8R0WNI3 reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@8R0WNI3 8R0WNI3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please remove your WIP commit from this PR (again) :^)

@ccwienk ccwienk force-pushed the base-component-descriptor-workflow branch from 15c27de to ae16c13 Compare January 13, 2025 11:52
@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Jan 13, 2025
@gardener-robot gardener-robot removed the size/l Size of pull request is large (see gardener-robot robot/bots/size.py) label Jan 13, 2025
@ccwienk
Copy link
Member Author

ccwienk commented Jan 13, 2025

Also, please remove your WIP commit from this PR (again) :^)

🙈
while working, I used to do:

  • add new changes/fixes for existing commits (except the topmost WIP-one) + git-commit using --fixup
  • run git rebase --autosquash
  • run git-push against my fork + this pullrequest (using @~ as ref to push)

apparently, the last rebase did not properly do autosquashing, resulting in the wrong commit to be skipped 🤦🏻‍♂️

@ccwienk
also accept lists of labels as --label argument
0888b35 
Make `ocm create` more convenient and also allow passing lists of
labels, rather than requiring multiple `--label` parameters. This is
particularly useful for usage in (shell-)scripts / GitHub-Actions, where
converting arrays is much more cumbersome.
@ccwienk
factor-out labels-parsing into function
1da0f72
@ccwienk
allow passing of labels for ocm append
fc92143 
Accept optional labels to be injected into artefacts. This is convenient
for (shell-)scripts as handling special-cases (single label vs.
multiple labels) is quite cumbersome.
@ccwienk
re-usable workflow for generating base-component-descriptor
ec1be3d 
"Base-Component-Descriptor(s)" have been proven to be beneficial for
integrating OCM-Component-Descriptors into CICD-Pipelines. Implement a
reusable workflow that will generate a base-component-descriptor to
avoid boilerplate in downstream pipelines.

This is a preliminary for enabling both a stand-alone
`component-descriptor` workflow/action(s), as well as support for
draft-release-pipelines (which can operate on
base-component-descriptors).
@ccwienk ccwienk force-pushed the base-component-descriptor-workflow branch from ae16c13 to ec1be3d Compare January 13, 2025 17:16
@gardener-robot gardener-robot added the size/l Size of pull request is large (see gardener-robot robot/bots/size.py) label Jan 13, 2025
@gardener-robot gardener-robot removed the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Jan 13, 2025
@ccwienk ccwienk merged commit f62bb61 into master Jan 13, 2025
11 checks passed
@ccwienk ccwienk deleted the base-component-descriptor-workflow branch January 13, 2025 17:19
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8R0WNI3 8R0WNI3 8R0WNI3 left review comments

@zkdev zkdev Awaiting requested review from zkdev zkdev is a code owner

Assignees
No one assigned
Labels
needs/review Needs review needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccwienk @8R0WNI3 @gardener-robot