Skip to content

Conversation

@tchinmai7
Copy link

@tchinmai7 tchinmai7 commented Sep 19, 2025

How to categorize this PR?

/area backup
/area disaster-recovery
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #914

Special notes for your reviewer:
Please read the discussion in the issue

Release note:

* Operators can now configure a secondary target for backup storage

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2025

CLA assistant check
All committers have signed the CLA.

@gardener-robot
Copy link

@tchinmai7 Labels area/todo, kind/todo do not exist.

@gardener-prow gardener-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 19, 2025
@gardener-prow
Copy link

gardener-prow bot commented Sep 19, 2025

Hi @tchinmai7. Thanks for your PR.

I'm waiting for a gardener member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Sep 19, 2025
@gardener-robot-ci-2
Copy link
Contributor

Thank you @tchinmai7 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@ishan16696
Copy link
Member

can you please also add a document for this feature, so that it will be easy for us to follow ... may be here: https://github.com/gardener/etcd-backup-restore/tree/master/docs/usage with any relevant name.

@tchinmai7
Copy link
Author

can you please also add a document for this feature, so that it will be easy for us to follow ... may be here: https://github.com/gardener/etcd-backup-restore/tree/master/docs/usage with any relevant name.

added in 9694aec

@tchinmai7 tchinmai7 marked this pull request as ready for review October 10, 2025 20:38
@tchinmai7 tchinmai7 requested a review from a team as a code owner October 10, 2025 20:38
@gardener-robot gardener-robot added area/backup Backup related area/disaster-recovery Disaster recovery related kind/enhancement Enhancement, improvement, extension labels Oct 10, 2025
@tchinmai7
Copy link
Author

@ishan16696 did you get a chance to review?

@ishan16696
Copy link
Member

Hi @tchinmai7 ,
I didn't get a time to review it, I will be able to review it next week, sorry for the delay.

@renormalize
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/backup Backup related area/disaster-recovery Disaster recovery related kind/enhancement Enhancement, improvement, extension needs/review Needs review needs/second-opinion Needs second review by someone else needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple S3 Backend support

6 participants