Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix-v0.23] Fixed predicates to allow events for Etcd resource that have never been reconciled before #904

Merged
merged 1 commit into from
Oct 29, 2024
Merged

[hotfix-v0.23] Fixed predicates to allow events for Etcd resource that have never been reconciled before #904

merged 1 commit into from
Oct 29, 2024

Conversation

anveshreddy18
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind bug

What this PR does / why we need it:
Cherry picks PR: #900

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixes the predicate to allow update events for existing Etcd resource that never got reconciled before.

@anveshreddy18 anveshreddy18 requested a review from a team as a code owner October 29, 2024 10:34
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/bug Bug size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Oct 29, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 29, 2024
unmarshall
unmarshall approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 29, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 29, 2024
@anveshreddy18 anveshreddy18 changed the title [hotfix-v0.23] Fixed predicates to allow events for Etcd resource that have never be… [hotfix-v0.23] Fixed predicates to allow events for Etcd resource that have never been reconciled before Oct 29, 2024
@unmarshall unmarshall merged commit 43227ab into gardener:hotfix-v0.23 Oct 29, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renormalize renormalize renormalize approved these changes

@unmarshall unmarshall unmarshall approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anveshreddy18 @unmarshall @renormalize @gardener-robot-ci-2 @gardener-robot