Skip to content

Remove initscript on Docker::Run ensure => absent #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmcbm wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove initscript on Docker::Run ensure => absent #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3c3893
Remove initscript on Docker::Run ensure => absent
bmcbm Mar 9, 2017
ad95259
Merge remote-tracking branch 'upstream/master'
bmcbm Nov 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions manifests/run.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,10 @@
timeout => 0
}

file { $initscript:
ensure => absent,
}

}
else {
file { $initscript:
Expand Down
3 changes: 2 additions & 1 deletion spec/defines/run_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
else
it { should contain_file(initscript).with_content(/Required-Start:.*\s+docker-foo/) }
it { should contain_file(initscript).with_content(/Required-Start:.*\s+docker-bar/) }
it { should contain_file(initscript).with_content(/Required-Start:.*\s+docker-foo_bar-baz/) }
it { should contain_file(initscript).with_content(/Required-Start:.*\s+docker-foo_bar-baz/) }
end
end
end
Expand Down Expand Up @@ -706,6 +706,7 @@
it { should compile.with_all_deps }
it { should contain_service('docker-sample').with_ensure(false) }
it { should contain_exec("remove container docker-sample").with_command('docker rm -v sample') }
it { should contain_file(initscript).with_ensure('absent') }
end

end
Expand Down