fix: make bin root detection CDPATH-safe#836
Open
Gujiassh wants to merge 1 commit intogarrytan:mainfrom
Open
Conversation
Redirect the bootstrap cd command to /dev/null so CDPATH cannot inject an extra path line into GSTACK_DIR and corrupt script-local path resolution. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/scripts suppresscdstdout while resolvingGSTACK_DIRCDPATHfrom injecting an extra path line into$(cd ... && pwd)command substitutions and corrupting downstream file pathsgstack-update-check) with a manual reproduction that now succeeds underCDPATHFixes #824.
Testing
bash -n bin/dev-setup bin/dev-teardown bin/gstack-community-dashboard bin/gstack-telemetry-log bin/gstack-telemetry-sync bin/gstack-uninstall bin/gstack-update-checktmpdir=$(mktemp -d) && printf '999.0.0\n' > "$tmpdir/VERSION" && export CDPATH='.:/tmp' && export GSTACK_STATE_DIR="$tmpdir/state" && export GSTACK_REMOTE_URL="file://$tmpdir/VERSION" && bin/gstack-update-check --force