FIX: Move server key from repository in terraform modules #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alhusseinsamy
requested review from
karimatwa and
tpetillot
and removed request for
karimatwa
karimatwa
requested changes
Oct 24, 2025
There was a problem hiding this comment.
This change needs to be implemented from the outside moving inward.
Here’s the plan:
- Revert the recent changes.
- Move the server configuration from the private package to the control plane in the existing private locations and package samples and add it to the private locations samples.
- Propagate this change through the modules and their inputs, as well as the submodules and their inputs.
- Add the server configuration to the control plane configuration for ECS, container-app, and VM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.