Chore: Use enum for handling bid sorting#76
Open
0ex-d wants to merge 1 commit intogattaca-com:developfrom
Open
Chore: Use enum for handling bid sorting#760ex-d wants to merge 1 commit intogattaca-com:developfrom
0ex-d wants to merge 1 commit intogattaca-com:developfrom
Conversation
0w3n-d
force-pushed
the
develop
branch
2 times, most recently
from
9c91283 to
50ccea9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used
BidsOrderByenumOption<BidsOrderBy>in place ofOption<i8>.Please follow this issue regarding my suggestion.
Bonus:
While running tests, noticed
#[ignore = "TODO: to fix"], could someone please clarify on this?helix/crates/database/src/postgres/postgres_db_service_tests.rs
Lines 590 to 592 in f26f257
Closes #73