Fixed bugs and inconsistencies in benchmarks#2
Open
s8phsaue wants to merge 1 commit intogavlegoat:mainfrom
Open
Fixed bugs and inconsistencies in benchmarks#2s8phsaue wants to merge 1 commit intogavlegoat:mainfrom
s8phsaue wants to merge 1 commit intogavlegoat:mainfrom
Conversation
s8phsaue
commented
May 26, 2025
- fixed several occurences in method 'unsafe' where 'self.state' instead of the argument 'state' was used
- adjusted 'max_episode_steps' check to greater equal (for consistency)
- removed 'self.unsafe' call in 'step'. The reason here is that the original code calls 'env.unsafe' directly after therefore making it redundant. Furthermore, by removing the call to 'unsafe' we can explore algorithms that use, e.g., a cost limit greater equal than 1.
- fixed road2d's and noisyroad2d's 'unsafe' method to use velocity instead of position
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.