Skip to content

Comments

Fixed bugs and inconsistencies in benchmarks#2

Open
s8phsaue wants to merge 1 commit intogavlegoat:mainfrom
s8phsaue:fix_benchmarks
Open

Fixed bugs and inconsistencies in benchmarks#2
s8phsaue wants to merge 1 commit intogavlegoat:mainfrom
s8phsaue:fix_benchmarks

Conversation

@s8phsaue
Copy link

  • fixed several occurences in method 'unsafe' where 'self.state' instead of the argument 'state' was used
  • adjusted 'max_episode_steps' check to greater equal (for consistency)
  • removed 'self.unsafe' call in 'step'. The reason here is that the original code calls 'env.unsafe' directly after therefore making it redundant. Furthermore, by removing the call to 'unsafe' we can explore algorithms that use, e.g., a cost limit greater equal than 1.
  • fixed road2d's and noisyroad2d's 'unsafe' method to use velocity instead of position

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant