-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start migration from float64 to big.Float #232
base: master
Are you sure you want to change the base?
Start migration from float64 to big.Float #232
Conversation
☔ The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts. |
Hi, please rebase your PR on fresh master. It has reworked chain interface. Instead of: r.chain.enter("XXX()")
defer r.leave()
if r.failed() {
return r
} we should now use: opChain := r.chain.enter("Decode()")
defer opChain.leave()
if opChain.failed() {
return r
} In other words, chain.enter() now returns a new chain instance, and we should use it for all other operations with chain. This change is part of making this lib thread-safe. Related commits: |
BTW if you don't mind, could you rollback reordering of methods in this PR? No problem with reordering itself, but it makes the diff a mess and it's hard to tell what changed exactly. |
Sure. Would rollback the ordering. Actually When I raised this PR initially I had conflicts which upon resolving messed up the ordering of the functions. I will revert it to initial ordering. |
43b0a86
to
ee27d9f
Compare
d159043
to
7d9207b
Compare
☔ The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts. |
Could you please revert unrelated changes (like formatting) in tests? This is a big pr, and it makes reviewing harder. |
Also please remove commented code |
Could you also provide a short summary of what is addressed by this pr and what is not? |
☔ The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts. |
Sure. Let me resolve conflicts and revert formatting changes. Give me few days. |
Hey @gavv reverted the formatting changes. Also short summary -
|
☔ The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts. |
af44eb7
to
ca0e087
Compare
#191