feat(gha): support macos #428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not suprisingly, tests fails on windows because I presume file schemas.. I will split this into 2 and do the windows in a different PR, as it requires code changes and I can give value by adding this macos validation now |
georgettica
changed the title
will do it in a different PR :)
|
also, golangci got a timeout, might be a good idea to cache it to remove issues for the next build? |
georgettica
changed the title
|
GHA windows issue: |
|
☔ The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts. |
github-actions
bot
added
the
needs rebase
|
Hi, thanks for PR, but we already had one: #426 |
|
I am glad it's closed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #413
not sure if someone did or didn't just though that as it's taking for so long I will just start and ask forgiveness if someone has already started and close mine