Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds dummy animation for the root scene node #429

Open
wants to merge 6 commits into
base: gz-common5
Choose a base branch
from
Open

Adds dummy animation for the root scene node #429

wants to merge 6 commits into from

Conversation

onurtore
Copy link

@onurtore onurtore commented Aug 22, 2022 •
edited
Loading

馃 Bug fix

Fixes #393

Summary

Adds dummy animation for the root scene.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Onur Berk Tore added 2 commits August 22, 2022 15:05
Adds dummy animation for the rootNode
69aba87 
Signed-off-by: Onur Berk Tore <[email protected]>
Removes unnessary changes
9b41015 
Signed-off-by: Onur Berk Tore <[email protected]>
@osrf-triage osrf-triage added this to Inbox in Core development Aug 22, 2022
@github-actions github-actions bot added the 馃尡 garden Ignition Garden label Aug 22, 2022
This was referenced Aug 22, 2022
Open
Open
@chapulina chapulina moved this from Inbox to In progress in Core development Aug 26, 2022
@chapulina chapulina added the bug Something isn't working label Aug 26, 2022
@onurtore onurtore marked this pull request as ready for review September 29, 2022 15:39
@azeey azeey added beta Targeting beta release of upcoming collection and removed beta Targeting beta release of upcoming collection labels Jul 31, 2023
@onurtore onurtore requested a review from marcoag as a code owner January 5, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luca-della-vedova luca-della-vedova Awaiting requested review from luca-della-vedova

@ahcorde ahcorde Awaiting requested review from ahcorde

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

@marcoag marcoag Awaiting requested review from marcoag marcoag is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working 馃尡 garden Ignition Garden
Projects
Core development
Status: In progress
Core development
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@onurtore @azeey @chapulina @mjcarroll @caguero