Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Utility coverage #283

Merged
merged 4 commits into from
Jul 23, 2022
Merged

Increase Utility coverage #283

merged 4 commits into from
Jul 23, 2022

Conversation

jennuine
Copy link
Contributor

@jennuine jennuine commented Jul 22, 2022

Part of gazebosim/gz-sim#1575

Summary

  • Increased Utility.cc coverage by adding tests for ConvertFuelMetadata methods
  • Updated ConvertFuelMetadata(string, msgs::FuelMetadata) function to take care of <world>: a1d294d (commit message is backwards 😅)
  • Removed unused split function: 8ff8356

Test it

./path/to/build/UNIT_Utility_TEST --gtest_filter="*ConvertFuelMetadata"

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@jennuine jennuine added the QA Quality assurance. label Jul 22, 2022
@jennuine jennuine requested a review from chapulina July 22, 2022 02:17
@jennuine jennuine requested a review from caguero as a code owner July 22, 2022 02:17
@jennuine jennuine self-assigned this Jul 22, 2022
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jul 22, 2022
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #283 (57a1081) into ign-msgs5 (63b8bf6) will increase coverage by 11.85%.
The diff coverage is 100.00%.

❗ Current head 57a1081 differs from pull request most recent head c86f6d1. Consider uploading reports for the commit c86f6d1 to get more accurate results

@@              Coverage Diff               @@
##           ign-msgs5     #283       +/-   ##
==============================================
+ Coverage      85.27%   97.12%   +11.85%     
==============================================
  Files              9        9               
  Lines            903      905        +2     
==============================================
+ Hits             770      879      +109     
+ Misses           133       26      -107     
Impacted Files Coverage Δ
src/Utility.cc 100.00% <100.00%> (+18.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b8bf6...c86f6d1. Read the comment docs.

@chapulina chapulina added the tests Broken or missing tests / testing infra label Jul 22, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the coverage efforts resulting in implementation improvements 😃

src/Utility.cc Outdated Show resolved Hide resolved
src/Utility.cc Show resolved Hide resolved
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll leave it up to you if you think the nitpick is worth addressing.

Signed-off-by: Jenn Nguyen <[email protected]>
@chapulina chapulina merged commit b344d98 into ign-msgs5 Jul 23, 2022
@chapulina chapulina deleted the jennuine/utility_coverage branch July 23, 2022 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11 QA Quality assurance. tests Broken or missing tests / testing infra
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants