Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove entity node #629

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Conversation

Wiktor-99
Copy link
Contributor

🎉 New feature

Summary

Add remove entity node (complementary to create)

Test it

Run gz sim with any entity and call remove launch as follows:

ros2 launch ros_gz_sim gz_remove_model.launch.py world:='world_name' entity_to_remove_name:='entity_name'

Test are also provided.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

ros_gz_sim/CMakeLists.txt Show resolved Hide resolved
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small nits, otherwise LGTM

ros_gz_sim/CMakeLists.txt Outdated Show resolved Hide resolved
ros_gz_sim/src/remove.cpp Show resolved Hide resolved
@Wiktor-99
Copy link
Contributor Author

Done

@ahcorde ahcorde merged commit 04446e0 into gazebosim:ros2 Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants