Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entries: Bung 1st compo #204

Merged
merged 11 commits into from
Sep 26, 2023
Merged

Conversation

dag7dev
Copy link
Contributor

@dag7dev dag7dev commented Sep 21, 2023

Close #183

"gbajam21",
"gbcompo21",
"gbcompo21-shortlist",
"gbprinter",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file got auto-formatted probably and introduced a bunch of unrelated changes, can you please disable the formatter and only commit the additional tag ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe we could create an entry for "MM2000", the only one missing?

An entry with just the metadata and the GIF that can be found on the compo website but no ROM..

@dag7dev
Copy link
Contributor Author

dag7dev commented Sep 23, 2023

LGTM. Maybe we could create an entry for "MM2000", the only one missing?

An entry with just the metadata and the GIF that can be found on the compo website but no ROM..

Should we create an issue about "Lost homebrews" instead? Probably we're gonna to find out other roms...

entries/Wonderworm-Willy/game.json Outdated Show resolved Hide resolved
@dag7dev dag7dev requested a review from avivace September 24, 2023 19:01
@avivace avivace merged commit 5b571de into gbdev:master Sep 26, 2023
1 check passed
avivace added a commit that referenced this pull request Sep 26, 2023
* entries: Bung 1st compo

* enh: missing arcade tag

* enh: sort tags in schema

* fix: space panic has GB platform

* fix: space panic slug

* fix: spr4col gb extension

* revert: tags order + added only newer ones

* enh: psst's tags have been added

* upd: tags on wonderworm willy entry

* add: willy wonderworm original readme

* enh: removed not working duped willy entry

Co-authored-by: avivace <[email protected]>
@dag7dev dag7dev deleted the entries/bung-1st-compo branch September 27, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bung Enterprises 1st Coding Competition
2 participants