Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entries: Remove duplicates #222

Merged
merged 6 commits into from
Feb 3, 2024

Conversation

asiekierka
Copy link
Contributor

@asiekierka asiekierka commented Jan 31, 2024

Will solve #134

@asiekierka asiekierka force-pushed the 20240131-metadata-cleanup branch from fc065a0 to b6d75c2 Compare January 31, 2024 15:10
@asiekierka asiekierka changed the title entries: Metadata cleanup entries: Remove duplicates Jan 31, 2024
@asiekierka asiekierka force-pushed the 20240131-metadata-cleanup branch 2 times, most recently from 29ab15d to 84bea36 Compare February 1, 2024 18:29
@asiekierka asiekierka force-pushed the 20240131-metadata-cleanup branch from 0218e2d to db4d853 Compare February 1, 2024 18:55
@asiekierka asiekierka marked this pull request as ready for review February 1, 2024 19:49
@asiekierka asiekierka force-pushed the 20240131-metadata-cleanup branch from 231d1dc to 404d9fe Compare February 2, 2024 15:23
@dag7dev
Copy link
Contributor

dag7dev commented Feb 2, 2024

@asiekierka @avivace how has the cleanup been executed? Using a particular cleanup script? I remember doing similar work, but it was discarded at the time. #157
(for the sake of curiosity and clarity, nothing more!)

@asiekierka
Copy link
Contributor Author

asiekierka commented Feb 2, 2024

I edited every single duplicate entry by hand. That's the only way to ensure the "best" version of a given entry is preserved. Sometimes, I had to combine information from multiple entries.

@dag7dev
Copy link
Contributor

dag7dev commented Feb 2, 2024

@asiekierka I agree with you! I did the same thing at the time, and I remember this comment (#157 (comment)) where "at most 30 items were allowed".

Is this policy changed since then?

@asiekierka
Copy link
Contributor Author

asiekierka commented Feb 2, 2024

I wasn't aware of that policy :-) However:

(a) I split it into multiple commits, so they could be PR'd and reviewed separately if need be. I think the biggest single commit tackles 40 items total.
(b) I didn't do any other changes, which is why my PR has 635 diffs and not 2000+. Much smaller, thus easier to review.

@avivace avivace merged commit 0414927 into gbdev:master Feb 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants