Skip to content

Commit

Permalink
Fix typo in instruction encoding (#540)
Browse files Browse the repository at this point in the history
In the instruction set page, the binary for "ld [imm16], a" is set to 0xEC which is an invalid code. A one and a zero had been swapped. "ld [imm16], a" should be 0xEA
  • Loading branch information
MyselfLeo authored Jan 29, 2024
1 parent f026175 commit 62ae8a1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/CPU_Instruction_Set.md
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ Finally, the instruction "families" have been further grouped into four "blocks"
{{#bits 8 >
"<code>ldh [c], a</code>" 7:"1" 6:"1" 5:"1" 4:"0" 3:"0" 2:"0" 1:"1" 0:"0" ;
"<code>ldh [imm8], a</code>" 7:"1" 6:"1" 5:"1" 4:"0" 3:"0" 2:"0" 1:"0" 0:"0" ;
"<code>ld [imm16], a</code>" 7:"1" 6:"1" 5:"1" 4:"0" 3:"1" 2:"1" 1:"0" 0:"0" ;
"<code>ld [imm16], a</code>" 7:"1" 6:"1" 5:"1" 4:"0" 3:"1" 2:"0" 1:"1" 0:"0" ;
"<code>ldh a, [c]</code>" 7:"1" 6:"1" 5:"1" 4:"1" 3:"0" 2:"0" 1:"1" 0:"0" ;
"<code>ldh a, [imm8]</code>" 7:"1" 6:"1" 5:"1" 4:"1" 3:"0" 2:"0" 1:"0" 0:"0" ;
"<code>ld a, [imm16]</code>" 7:"1" 6:"1" 5:"1" 4:"1" 3:"1" 2:"1" 1:"0" 0:"0" ;
Expand Down

0 comments on commit 62ae8a1

Please sign in to comment.