Merge pull request #11 from gchiesa/first-release

feat: prepare initial release

.github/workflows/go-ci-lint.yaml

@@ -0,0 +1,29 @@
+---
+name: Go linter
+on:
+  workflow_dispatch:
+  push:
+  pull_request:
+permissions:
+  contents: read
+  pull-requests: read
+jobs:
+  golangci:
+    name: Golangci-lint
+    runs-on: ubuntu-latest
+    env:
+      GO_VERSION: '~1.22'
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Go
+      uses: actions/setup-go@v4
+      with:
+        go-version: ${{ env.GO_VERSION }}
+        cache: false
+    - name: golangci-lint
+      uses: golangci/golangci-lint-action@v3
+      with:
+        version: v1.56
+        args: --config .golang-ci.yml
+        github_token: ${{ secrets.GITHUB_TOKEN }}
+        reporter: github-pr-check

.github/workflows/go-ci-test.yaml

@@ -0,0 +1,20 @@
+---
+name: Go unit tests
+on:
+  workflow_dispatch:
+  push:
+  pull_request:
+env:
+  GO_VERSION: '~1.22'
+jobs:
+  golangci:
+    name: Go Tests
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Go
+      uses: actions/setup-go@v4
+      with:
+        go-version: ${{ env.GO_VERSION }}
+    - name: Test
+      run: make test

.github/workflows/test.yml

@@ -1,12 +1,14 @@
 name: Test and coverage
 
-on: [push, pull_request]
+on:
+  workflow_dispatch:
+
 
 jobs:
   test:
     strategy:
       matrix:
-        go-version: [1.19.x]
+        go-version: [1.22.x]
         os: [ubuntu-latest, macos-latest, windows-latest]
 
     runs-on: ${{ matrix.os }}

.golang-ci.yml

@@ -46,6 +46,8 @@ linters-settings:
     - singleCaseSwitch
     - hugeParam
     - appendCombine
+    - sloppyReassign
+    - whyNoLint
   funlen:
     lines: 100
     statements: 52

go.mod

@@ -1,6 +1,6 @@
 module github.com/gchiesa/ska
 
-go 1.21
+go 1.22
 
 toolchain go1.22.0
 

internal/tui/collector.go

@@ -34,7 +34,7 @@ func (m *Model) Init() tea.Cmd {
 }
 
 func (m *Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
-	var cmds []tea.Cmd = make([]tea.Cmd, len(m.inputs))
+	var cmds = make([]tea.Cmd, len(m.inputs))
 
 	for i := range m.inputs {
 		m.inputs[i], cmds[i] = m.inputs[i].Update(msg)
@@ -84,7 +84,7 @@ func (m *Model) View() string {
 	builder.WriteRune('\n')
 	builder.WriteString(helpStyle.Render(" ↑, ↓: navigate, enter: confirm, ctrl+c: quit, ctrl+s: save"))
 	if m.err != nil {
-		builder.WriteString(errorStyle.Render(fmt.Sprintf("%s", m.err.Error())))
+		builder.WriteString(errorStyle.Render(m.err.Error()))
 	}
 	return builder.String()
 }

internal/tui/type.go

@@ -1,15 +1,13 @@
 package tui
 
 import (
-	"github.com/charmbracelet/bubbles/cursor"
 	"github.com/charmbracelet/bubbles/textinput"
 )
 
 type Model struct {
 	header        string
 	focusIndex    int
 	inputs        []textinput.Model
-	cursorMode    cursor.Mode
 	err           error
 	exitWithCtrlC bool
 }

pkg/skaffolder/create.go

@@ -16,7 +16,7 @@ type SkaCreate struct {
 	Log             *log.Entry
 }
 
-func NewSkaCreate(templateURI string, destinationPath string, variables map[string]string) *SkaCreate {
+func NewSkaCreate(templateURI, destinationPath string, variables map[string]string) *SkaCreate {
 	logCtx := log.WithFields(log.Fields{
 		"pkg": "skaffolder",
 	})

pkg/skaffolder/update.go

@@ -69,7 +69,6 @@ func (s *SkaUpdate) Update() error {
 
 	// check if interactive mode is required
 	if interactiveService.ShouldRun() {
-
 		// overrides the variables from remote service with already saved variables
 		interactiveService.SetDefaults(mapInterfaceToString(vars))