fix: implement support for multiple local ska-config.yaml #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is done by moving from single yaml file to directory with list of yamls
gchiesa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 What
As per #55 SKA should support scaffolding multiple folders in the same root.
For this reason a single yaml file is not sufficient anymore and the choice is to change the approach to a dedicated directory
.ska-configholding all the configurations inside.Each template can be associated to a named config so that
ska updatewill know what information retrieve.If no name is passed for the configuration then the default config name will be used.
However, if there is already a configuration of there are multiple configurations, then the name is required.
🤔 Why
To support issue #55
📚 References
closes #55