Enable Mongo transactions for updating model cards #1237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCHQDeveloper36
force-pushed
the
dev/use-mongo-transactions
branch
from
f9028a4 to
c556248
Compare
GCHQDeveloper36
force-pushed
the
dev/use-mongo-transactions
branch
from
92d8326 to
eb8721d
Compare
GCHQDeveloper36
force-pushed
the
dev/use-mongo-transactions
branch
from
eb8721d to
f0bc1a0
Compare
GCHQDeveloper36
force-pushed
the
dev/use-mongo-transactions
branch
from
af86873 to
55c97ad
Compare
JR40159
requested changes
Apr 28, 2025
GCHQDeveloper36
force-pushed
the
dev/use-mongo-transactions
branch
from
55c97ad to
2bbc169
Compare
|
I've refactored based on the latest comments/discussions, as well as added some basic tests in. I don't think there's much I can do about requiring 'knowledge' of the session within the backend service code without rewriting and introducing a heap of 'new' code to override the existing mongoose methods. But, if there's no session, it should be silently dropped and unused. |
ARADDCC002
requested changes
May 12, 2025
GCHQDeveloper36
force-pushed
the
dev/use-mongo-transactions
branch
from
4223d0d to
9988e82
Compare
|
Squashed and rebased against v2.7.0 |
GCHQDeveloper36
force-pushed
the
dev/use-mongo-transactions
branch
from
9988e82 to
ef28c6d
Compare
|
Rebased against main (v2.8.1) |
GCHQDeveloper36
force-pushed
the
dev/use-mongo-transactions
branch
from
ef28c6d to
a00a7c2
Compare
GCHQDeveloper36
force-pushed
the
dev/use-mongo-transactions
branch
from
a00a7c2 to
39cd96f
Compare
|
Rebased against main (v2.9.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Depends on #1236)
Suggested implementation for transactions around updating model cards - possibly consider this WIP until there's been some further testing done by others.