Fix bad avScan migration leaving legacy object rather than array #2052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since migrating
File.avScan
to its ownScan
mongo Document, migration script 009 fails due to using.get
on alean
object (POJO i.e. not a hydrated Document) within anasync forEach
loop which is not awaited, resulting in 009 appearing to pass when it has failed. 012 would then fail as it expectedFile.avScan
to be an array orundefined
but was getting objects which it couldn't handle.This PR fixes these problems by:
find
in 009 no longer uselean
forEach
loop tofor ... of
in 009Mixed
mongooseSchemaType
by explicitly marking as modified