Fixed bug with userdisplay and latestrelease #2053
Conversation
|
Ubuntu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 similar comment
|
Ubuntu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| {` ${formatDateString(file.createdAt.toString())}`} | ||
| {sortedAssociatedReleases.length > 0 && ( | ||
| <Typography textOverflow='ellipsis' overflow='hidden' variant='caption' sx={{ mb: 2 }}> | ||
| Added by <UserDisplay dn={sortedAssociatedReleases[sortedAssociatedReleases.length - 1].createdBy} />{' '} |
There was a problem hiding this comment.
"Added by" about a file is different to who created one of the associated releases. Also how would this work if a file wasn't associated to any releases?
There was a problem hiding this comment.
To my knowledge the user who uploaded the file is only stored in the release. This means if a file in the future was able to be uploaded separately to a release, I don't think you could display the release of the uploader until the file store holds the name of the uploader.
There was a problem hiding this comment.
So we don't store who uploaded a file, but we do store who created a release but those are different things. As a result I don't think we can have "Added by" on a file because we don't have that information.
| </Typography> | ||
| )} | ||
| </Stack> | ||
| <Stack direction={{ sm: 'column', md: 'row' }} spacing={0.5} alignItems='center' justifyContent='flex-start'> |
There was a problem hiding this comment.
I don't think we need to break these two bits up as they're the same sentence. Instead I would remove this <Stack /> and replace it with:
Uploaded on <span style={{fontWeight: 'bold'}}>{${formatDateString(file.createdAt.toString())}}
| </Typography> | ||
| </Stack> | ||
| </Stack> | ||
| <Typography variant='caption' sx={{ mb: 2 }}> |
There was a problem hiding this comment.
We don't need this padding at the bottom
|
Moved to #2060 |
No description provided.