Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static type checker complaints for benchmarking #912

Open
tp832944 opened this issue Jan 2, 2025 · 1 comment · May be fixed by #935
Open

Fix static type checker complaints for benchmarking #912

tp832944 opened this issue Jan 2, 2025 · 1 comment · May be fixed by #935
Assignees
@qh681248

Comments

@tp832944
Copy link
Contributor

tp832944 commented Jan 2, 2025

What's the issue?

Obtain Pyright pass on the benchmarking folder. See #744 for guidance.
@tp832944 tp832944 added new Something yet to be discussed by development team and removed new Something yet to be discussed by development team labels Jan 2, 2025
@tp832944 tp832944 mentioned this issue Jan 2, 2025
Open
1 task
@tp832944 tp832944 assigned tp832944 and qh681248 and unassigned tp832944 and qh681248 Jan 6, 2025
@qh681248 qh681248 self-assigned this Jan 20, 2025
qh681248 added a commit that referenced this issue Jan 21, 2025
@qh681248
fix: pyright fixes
62cfb83 
#912
@qh681248 qh681248 linked a pull request Jan 21, 2025 that will close this issue
Open
9 tasks
@qh681248 qh681248 linked a pull request Jan 21, 2025 that will close this issue
fix: Fix pyright type checks on benchmark directory #935
Open
9 tasks
qh681248 added a commit that referenced this issue Jan 21, 2025
@qh681248
chore: removed to-do comment
1c5a736 
#912
qh681248 added a commit that referenced this issue Jan 21, 2025
@qh681248
chore: added pyright-benchmark fixes to changelog
8c17210 
#912
qh681248 added a commit that referenced this issue Jan 21, 2025
@qh681248
chore: Merge add kernel-thinning-to-benchmarking branch to pyright-be…
98369c8 
…nchmarking branch

#912
@qh681248
Copy link
Contributor

Wait for #919 to be merged before reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qh681248 qh681248

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix pyright type checks on benchmark directory gchq/coreax
2 participants
@tp832944 @qh681248